JIRA cloud issue creation and availability issue#448
Conversation
There was a problem hiding this comment.
I'm OK with this as is, since we very much want to stop creating duplicates, but I have a couple of concerns (and a bunch of suggestions).
First, I recommend changing the focus of _get_existing_jira_issue_query() (and its name) so that it returns the key list and not the JQL -- the caller can produce the JQL easily enough, and returning a naked tuple is something best to avoid unless there's a compelling need.
Second, you modified two access to use displayName, but their respective approaches are inconsistent...which is fine if it's justified, but my instinct is that one of them is "right" and one is "wrong" -- and I don't know which is which....
So, perhaps we could merge this and then you could polish it in a follow-up PR.
Code review fixes for PR #448
3 participants
Created this PR for solving the following issue:
After jira cloud issue creation instantly if you search for through JQL it won't return so for that we have used GET call as an alternative if the key is present in cache or in snowflake but not in JQL ...
As previously we are logging issue Id but it isn't that useful so we are now chnaged to the log the JQL contents it will help to debug in better way.
Updated to use displayName instead of name in
_update_Assigneeandcheck_comments_for_duplicate